Repository navigation
Prod: port program analytics and participation UI - #343
Merged
Merged
Conversation
…polish Prod: polish release UI and rating persistence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Контекст и база
master:2628a25266c4e23373f5fa78a710700e343740f7.99c8813a66f89560a946eab7d1de73ab2925d0f5.907ced23273e298314e9d8604dbaabb25ded6869, imageprod-907ced2.dev -> master, без cherry-pick merge-коммитов и без blanket-копирования DEV-файлов.Что перенесено
/office/program/:programId/analyticsс summary, воронками, регионами, activity SVG-графиком, zero/error/loading states.write-excel-file.programLinkId, включая системное полеcase, submission metadata и multi-program safety.currentProjectApplication: создать заявку / перейти в заявку / вы подали проект.datetimeEvaluationEnds, включая disabled CTA и readonly rating state.Production contracts
Legacy analytics использует только production namespace:
GET /programs/:programId/project-analytics/GET /programs/:programId/project-analytics/assignments/GET /programs/:programId/project-analytics/assignments/:assignmentId/scores/GET /programs/:programId/project-analytics/participants-without-team/GET /programs/:programId/project-analytics/projects-awaiting-evaluation/GET /programs/:programId/project-analytics/projects-not-submitted//manager-overview/не используется. Program detail читаетcurrent_project_applicationчерез существующийCamelcaseInterceptorкакcurrentProjectApplication; DEV-literalcurrentApplicationне используется.Canonical GET/PUT дополнительных полей выполняется через
/programs/partner-program-projects/:programLinkId/fields/.programLinkIdостаётся authoritative для GET/PUT/submit и не выводится из singularpartnerProgram.Сохранение production master
Сохранены production-only изменения и regression-контракты #304, #306, #310, #313 и #315. Vacancy-файлы/flow, shared
app-modal, production rating adapter URL, workflows, Docker иangular.jsonне менялись.Карта DEV references
Явно не включено
Dependencies
Добавлена только прямая зависимость
[email protected]; lock-файл добавляет только её транзитивную зависимость[email protected]. Прочие зависимости не обновлялись.Проверки
npm ci— успешно.npm run test:ciна локальном Node 24 — известныйNG0401на штатном pool до запуска тестов.ngx-autosize: window is not definedв неизменённомnews-form.component.spec.ts. Test infrastructure в этом PR не менялась; чистый CI run обязателен перед merge.npm run lint:ts— 0 errors, 6 существующих warnings в неизменённых файлах.npm run build:prod— успешно; только существующие Angular/Sass/CommonJS/budget warnings.git diff --check— успешно.git diff --exit-code -- .github Dockerfile angular.json— успешно./manager-overview/, нетcurrentApplication, нет diff в vacancy/shared-modal/rating-adapter/reset-password paths.Responsive smoke
Exact PR head:
fe416aa9be9f112c9f2c6bbe539ff946c15f8f3c.Draft only. Не merge и не deploy.